Remove the need for request_application
#3382
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Until now, applications were only available on chains that published them and ones that explicitly requested to use them using
request_application. This meant there was an awkward step for users that wanted to use others' applications on their own chains.Proposal
This PR changes
UserApplicationDescriptioninto a blob. Publishing an application means storing a blob, which is then accessible to all microchains right away. This removes the need forrequest_applicationand makes it possible to remove its functionality entirely.Test Plan
The example usage flow of the Request For Quotes application was tested manually in order to ensure that the RFQ app was available on other chains without it being explicitly requested.
The readme tests will ensure that this will be tested in CI as well.
Release Plan
Links